Comment 8 for bug 1943744

Revision history for this message
Steven Mayo (stmayo) wrote (last edit ):

Thanks for the suggestions, Jane!
'ng lint' said the if statements needed curly braces like you thought, as well as a few other things I wouldn't have thought of like indentation and the name of an event emitter. It's almost as if linting is a great tool that I should have remembered to use in the first place.
I've done everything ng lint told me to and removed the comments.

Also, oops, I forgot to remove the number from the line I copied for the upgrade script. It's XXXX again.

Importing FormsModule got 'npm run test' rolling again for me. Thanks for the tip!

Here's the branch with another commit for all the cleanup: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/LP1943744-Staff_Catalog_Preferences_Include_Checkboxes_And_Sort_Order