course details page doesn't correctly handle archived courses
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.8 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
If you bring up the staff details page of an archived course, it doesn't display correctly:
- the 'Archive' button is active
- none of the visual indicators that the course is archived (e.g., the lock icon) are displayed
This turns out to be caused by how eg-fm-record-editor automatically converts -- inline -- boolean IDL fields to Javascript true/false (from 't'/'f') if it's passed a record. Because the course details page defaults to an inline eg-fm-record-
A workaround is probably to pass a clone of currentCourse to the eg-fm-record-editor and ensure that currentCourse gets updated if a change is made via the editor.
A longer-term fix would be rethink what eg-fm-record-editor does to Boolean fields, or, more ambitiously, have the IDL service automatically take care of the Boolean conversions. Doing the latter would then mean updating a pile of Angular code to replace tests against 't' and 'f'.
Evergreen 3.6+
Changed in evergreen: | |
importance: | Undecided → Medium |
Changed in evergreen: | |
assignee: | nobody → Jane Sandberg (sandbergja) |
no longer affects: | evergreen/3.6 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Bug 1939998 expresses the wish of having the IDL service and friends handle the conversion transparently.