Comment 0 for bug 1918470

Evergreen Version 3.5.3 and master
OpenSRF versions: 3.2.1 and master
PostgreSQL version: 9.6 and 10

While testing bug 1207533 on master today, I noted a consistently reproducible internal server error when hitting "Continue" after placing a hold or hitting "Cancel" while placing a hold.

I have reproduced this behavior on a training server running Evergreen 3.5.3.

The error occurs in both the patron OPAC and in the web staff client.

The error message in the log suggested that the patch for bug 1914116 may have been to blame:

Mar 10 13:52:19 training root: [Wed Mar 10 13:52:19.001431 2021] [perl:warn] [pid 28901] [client 192.168.100.101:36754] egweb: template error: undef error - at /openils/var/templates/opac/parts/header.tt2 line 1.\n, referer: https://training.cwmars.org/eg/opac/place_hold?locg=119&detail_record_view=0&query=coelho&hold_source_page=%2Feg%2Fopac%2Fresults%3Fquery%3Dcoelho%26amp%3Bqtype%3Dkeyword%26amp%3Blocg%3D119%26amp%3Bdetail_record_view%3D0%26amp%3Bsort%3Dpoprel&hold_type=T&hold_target=385397

Reverting the commit for that bug, did clear up the internal server errors.

Discussion with Jason Boyer in IRC came to the conclusion that this is likely because the URLs are being filtered twice when holds are placed, thus entities are being re-encoded with percent encoding: http://irc.evergreen-ils.org/evergreen/2021-03-10#i_477445