Need to use html filter on mkurl() output
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Evergreen | Status tracked in Main | |||||
3.5 |
Confirmed
|
High
|
Unassigned | |||
3.6 |
Confirmed
|
High
|
Unassigned | |||
Main |
Confirmed
|
High
|
Unassigned |
Bug Description
Evergreen 3.5, 3.6, and master are affected.
So, recently we fixed bug 1687545 and now can sure that all query parameters consistently use ampersands rather than semicolons. Hurray!
But it turns out all of these semicolons were hiding areas where we were not using the necessary filters in our .tt2 files, so now things like the "Show more copies" link in the opac has changed from
.../eg/
to the new and exciting
.../eg/
which works about as well as one might expect.
The minimum required fix to correct this is to run anything that has query parameters and will end up in an 'a' tag href attribute through the html filter, though there may be times where multiple filters may be needed.
description: | updated |
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Jason Boyer (jboyer) |
It looks like this can easily be handled in mkurl() itself. Since we don't currently run mkurl() output through the html filter anywhere it's easier to use the filter directly inside the macro and not add it everywhere mkurl is ever used. Branch is at https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1914116_ html_filter / working/ user/jboyer/ lp1914116_ html_filter