Usability with Edit Hold Notification popup

[Terran McCanna]

In 3.4 & 3.6:

In the staff client, when editing a patron's hold notification preferences for an existing hold, the Edit popup displays with blank fields. There is no way to know what the existing values were set, so no way to tell what needs to be updated without going back to the patron's holds grid and displaying all of the relevant columns.

I expect this was probably done intentionally because multiple holds can be updated at once and each existing hold could have different settings, and I'm not sure of the best way to handle that.

Perhaps the existing values could display if only one hold is being edited? Or perhaps the patron's default values could be displayed to the right? There are probably better ways to approach it, but I feel sure that this process can be improved to make it less confusing for staff.

See also: https://bugs.launchpad.net/evergreen/+bug/1897798

[Jennifer Pringle (jpringle-u)]

Still an issue in 3.8.

We agree that the values should display when a single hold is being edited (and possibly when multiple holds are selected). It's confusing for staff when the fields are blank, especially if they didn't check what notification was being used. It's also not intuitive on how to remove notifications - it took me three tries to remove an email address.

[Jennifer Pringle (jpringle-u)]

Bug specific to removing emailing notification - https://bugs.launchpad.net/evergreen/+bug/1897798

Bug specific to issues un-setting phone and SMS notifications - https://bugs.launchpad.net/evergreen/+bug/1825426

[Lindsay Stratton (lstratton)]

Still an issue, along with the other quirks, in 3.10.

[Susan Morrison (smorrison425)]

I am not sure if this issue can be lumped into this bug, or if I should create a separate bug report for it, but for 3.10+, when updating a patron's user settings for holds notices in the staff client, the pop-up to edit existing holds does not always appear. This recently caused confusion with library staff when they were updating a patron's preferences from email|sms to phone, and the pop-up did not appear with any of their updates and the existing holds weren't updated. Staff can always update notifications for existing holds through the holds tab, but the pop-up should appear anytime the user settings are updated.

I've tested numerous combinations of edits and unfortunately cannot see a pattern for when the pop-up does not appear. Initially, I thought that changing the holds notices from multiple options to one option (ex: changing email and sms to phone), but there has been inconsistent behavior across the board.