Course List should be limited to user's working location

Bug #1905068 reported by Beth Willis
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.6
Fix Released
Medium
Unassigned

Bug Description

In Course Materials, users can add and manage courses on the Course List page.  Currently, the Course List includes course created by users from other working locations.  It does not appear that users can add materials to courses not owned by their working location, but they are able to remove items associated with courses not owned by their working location.

Staff users should be able to access only courses related to their own working locations.

EG 3-6-0

Revision history for this message
Beth Willis (willis-a) wrote :
Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
importance: Undecided → Medium
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I will be working on this on behalf of BC Libraries Cooperative. My plan is to add an org family filter (with the Ancestors/Descendants checkboxes) to the course list. It will default to the workstation org unit, but still allow, say, somebody at a main campus to view courses at a branch library. It will only show orgs where the user has the MANAGE_RESERVES permission, however.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here is a branch: user/sandbergja/lp1905068_add_org_family_selector_to_course_list

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1905068_add_org_family_selector_to_course_list

And here are the testing notes from the commit message:

1) Apply this patch
2) Admin > Local admin > Course reserves list
3) Check that the list defaults to courses available at your workstation org unit
4) Check that, when you select ancestors, descendants, or a different org unit, the course list updates accordingly
5) Check that the list only displays org units for which you have the MANAGE_RESERVES permission

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
tags: added: pullrequest
Revision history for this message
Christine Burns (christine-burns) wrote :

I have tested this code and consent to signing off on it with my name, Christine Burns and my email address, <email address hidden>

tags: added: signedoff
removed: pullrequest
tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote (last edit ):

There's a problem with this line:

  defaultOuId = 1;

There's no guarantee that the root of the OU tree has ID = 1, and I know of at least one production Evergreen system where that's not the case. Importing OrgService and getting the default from org.root() would resolve this.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Galen. I made the correction you recommended, amended my commit, and force-pushed it to the same branch.

Revision history for this message
Galen Charlton (gmc) wrote :

Pushed on down to rel_3_6. Thanks, Jane and Christine. (Also, apologies, Christine, I forgot to add your signoff to the commit).

Changed in evergreen:
milestone: none → 3.7.2
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.