Angular Catalog: Placing Suspended Hold allows Activation Date in the past

[Michele Morgan]

Evergreen 3.6

When a staff member places a hold on behalf of a patron and suspends the hold at time of placement, an activation date can be set.

The Angular Catalog allows a date in the past to be chosen and saved.

In the Traditional catalog a pop-up prevents a past date from being saved.

Bug 985957 fixed this in the Traditional catalog

[John Amundson (jamundson)]

I am currently testing 3.6.1 for CW MARS.

I can confirm "seeing" this behavior.

In our setup, however, even when an activation date is set on the Place Hold screen, no actual thaw_date is stored with the hold, regardless of if the chosen date was in the past or future. This only happens with the Angular Catalog.

Are you finding this to be true, as well, or are you seeing thaw_dates actually being attached?

[Michele Morgan (mmorgan)]

To answer John's question, I am seeing thaw_dates stored in holds that are suspended at time of placement. I've confirmed on three local servers that they are storing as they should in 3.6.1, 3.6.2, and 3.6.3.

[Bill Erickson (berick)]

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1903357-angstcat-thaw-date-past

It includes 2 commits, one which allows you to clear the thaw date once a value has been applied (and have it actually update the model), then a second to enforce a future thaw date.

[Erica Rohlfs (erohlfs)]

I tested on Terran's Test Server 1 for Feedback, but I'm seeing the same behavior; I can still set an active date in the past and successfully place a hold. I'm un-assigning myself, so someone else can test.

[Josh Stompro (u-launchpad-stompro-org)]

I tested this on Terran's test server 1, and it seems to be working fine. This is just for the Angular staff interface, so that is the only interface I tested.

When I choose a date that isn't in the future, there is an error popup and it isn't possible to place the hold. I can clear the date by selecting it and deleting it, which clears the date selector... which I think is what the second patch is about.

I confirmed that the hold placed was frozen and did have an activation date set.

I'll submit a signoff branch as soon as I have a chance.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Signoff branch at
user/stompro/lp1903357-angstcat-thaw-date-past-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1903357-angstcat-thaw-date-past-signoff

Josh

[Bill Erickson (berick)]

Merged to 3.6 and up. Thanks, All.