Prevent hold activation date being a date in the past

[Jennifer Pringle]

Evergreen 2.0.10
OpenSRF 2.0.1
Postgress 8.4
OS: Ubu Lucid

When a patron suspends a hold in the OPAC they are able to enter a date that has already passed as the activation date. The system accepts this date and never activates the hold. The hold can only be activated manually by either the patron or a staff member.

This behaviour of allowing a past date is present in the TPac for 2.2 as well.

The staff client recognizes past dates and does not allow staff to set a past date.

[Jason Stephenson (jstephenson)]

I am removing the "opac" tag because this will not be fixed in JSPAC at this point. It is still a valid issue for tpac and possibly kpac as well. (I've not looked at kpac, yet.)

[Jason Stephenson (jstephenson)]

I plan to roll the fix for this into my fix for https://bugs.launchpad.net/evergreen/+bug/1076399 .

Should we mark this as a duplicate? I don't see much of a way to link bugs other than that.

[Jason Stephenson (jstephenson)]

Not going to do this one at this time. It is a tad more complicated than messing with expiration dates, since we'll likely need to interact with the user.

[Garry Collum (gcollum)]

This behavior is still true in TPac 3.0.7 and current master. The webclient also allows staff to input past activation dates.

[Jennifer Pringle (jpringle-u)]

Confirming this is still an issue in 3.1.7

[Terran McCanna (tmccanna)]

Confirmed still an issue in 3.2.3

[Suzanne Paterno (paterno)]

The OPAC also allows values that are not dates or even numbers. Dates that are not valid dates (outside the range of months, days or years) area also accepted.

[Suzanne Paterno (paterno)]

I wrote a new Javascript function to holds_validation.js to check that the date entered is a valid date in the future. Will post fix shortly.

[Suzanne Paterno (paterno)]

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/spaterno/lp985957_suspended_hold_date

[Jason Etheridge (phasefx)]

Suzanne, I squashed your two commits into one, added my signoff, and pushed it to collab/phasefx/lp985957 @ working/Evergreen.git

Could you add your signoff? Also, one other suggested tweak, disallow today's date as well as past dates, though I'd be happy pushing it in as is.

Thanks!

[Suzanne Paterno (paterno)]

I have tested this code and consent to signing off on it with my name, Suzanne Paterno, and my email address, <email address hidden>.

[Jason Etheridge (phasefx)]

Thanks! Pushed to master.

[Jennifer Pringle (jpringle-u)]

I tested this on our server running 3.5.0 and I can still enter and save an activation date that falls in the past.

[Galen Charlton (gmc)]

I've opened bug 1888554 based on Jennifer's report. The patch for this bug only affects the hold placement form, not the hold editing form.