Comment 13 for bug 1890822

Revision history for this message
Galen Charlton (gmc) wrote :

Upon review of the update, there are a couple problems:

- the penalty calculation doesn't check whether patron_id is set, and often it will not be (e.g., checkouts via SIP2, renewals, and checkins)
- that per se doesn't throw an error, but it pointed out a problem: various actions that could be blocked by a newly calculated standing penalty won't be caught, including SIP2 checkouts and renewals.

I think it may be necessary to move the penalty calculation closer to the point where we're sure that we have the patron ID if relevant... possibly as late as in run_indb_circ_test.