Comment 12 for bug 1890822

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Galen and Elizabeth. I pushed a second commit to user/sandbergja/lp1890822_patron_exceeds_overdue_count to incorporate the recommended changes. It no longer hard-codes a list of threshold-based penalties, since it turns out that this was not needed in the first place -- calculate_penalties only works with threshold-based penalties. It also moves the penalty check into its own transaction in run_method, updates the comment, and adds some additional checks to the perl live test to confirm that the penalties remain on the patron's account, even if the attempted checkout is rolled back.