Comment 67 for bug 1888723

Revision history for this message
Galen Charlton (gmc) wrote :

Some observations:

- If you edit an item and switch between the Holdings and Item Attributes tabs a round or two, the unsaved changes dialog appears even if you haven't made any changes. This looks like a side-effect of the change to avoid defaulting CN labels when editing a CN whose label is empty; ngOnInit should be invoking emitSaveChange() only when necessary in that case (which I guess means only if any of the labels are blank, although a further improvement might be to emit a different dialog that states that there's a data validation issue rather than unsaved changes).
- If the user hits the cancel button on the unsaved changes dialog, currently the changes-pending flag is cleared and the user can navigate away. Just double-checking that we want that behavior.
- Open the editor in add item mode, then click Generate Barcode: nothing happens. The Generate Barcode action seems to only start working if you add one more item in the holdings tab first.
- The item alerts, notes, and tags dialogs do not display existing values attached to the item. Is this intentional? Otherwise, that's a regression from the AngularJS volcopy editor.
- The currently contains references to both webstaff.cat.copy.templates and cat.copy.templates. Is one or the other intended?
- As a point of clarification, how are item templates supposed to be created? Create a new item, save it as a template, but don't save the item?

I think this is close, but the