Comment 3 for bug 1887866

Thanks for the comment, Terran. My intention was to make this particular bug focus on improving the shared Angular JS directives so that they can be made accessible. Not included in this was also also finding every place in Evergreen that these directives are in use and making those changes as well.

The work of finding every place in Evergreen that these directives are in use is included in the accessibility audit (Bug #1887857).

By doing it this way my hope was to modularize the work and make the changes incrementally. My thought was first we focus on improving the basic "building blocks" (directives), get those tested and merged, and then that opens the door to making future improvements easily. To me, this felt preferable to creating a single giant bug which touches many files spread over many areas of Evergreen. Other thoughts are welcome.

I probably should have made this more clear by giving testing instructions for this bug. Here's how my testing instructions would look:

1. Switch to the branch with my work for this bug (see comment #1 above)
2. Cherry pick some changes that use these shared directives, such as changes to patron pages accessibility. See Bug #1887869 see comment #3
3. Test both together, to confirm that the directives are now capable of being accessible.

What are your thoughts?