Return of the duplicated holds list

[Michele Morgan]

Evergreen 3.4.2

The following series of steps will reveal a display issue that duplicates the list of holds when viewing a bib record in the staff client:

- Perform a search
- Retrieve a record with holds and go to View holds
- Go back to the search results
- Retrieve the same record again and go to View holds

You will see the holds list is duplicated.

bug 1669907, fix released in 2.12.4, first addressed the issue but not the underlying cause
bug 1705286, has a patch attempting to address the underlying cause but appears to be obsolete

Bug 1712854, released in 3.2beta, introduced a new api to retrieve hold data.

I'm marking 1705286 as a duplicate of this bug for continuity

[Elizabeth Taron (etaron)]

tested on upstream 3.3, bug as described

[Bill Erickson (berick)]

Confirmed in 3.5 as well.

[Bill Erickson (berick)]

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1865564-rec-holds-grid-dupes

I identified 2 issues that required fixing:

1. Avoid fetching holds when the pickup lib selector fires its on change if the value provided matches the pickup lib we are already using.

2. Avoid resetting and reloading the grid during an active grid load. Instead wait for the current load to complete before launching the next load action.

[Bill Erickson (berick)]

Removing pullrequest for now. Fix addresses the issue but creates a secondary problem. After a 'Request Items' action in the holdings view, the newly placed holds are not displaying in the holds grid, because it's serving the holds from cache.

[Bill Erickson (berick)]

Fix for my previous comment pushed to same branch.

[Michele Morgan (mmorgan)]

I've tested this on the Feedback Fest test server and was not able to get the hold list to duplicate. Signoff branch forthcoming.

[Michele Morgan (mmorgan)]

Here's my signoff branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1865564_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_5, and rel_3_4. Thanks, Bill and Michele!