webstaff: grid fetch for View Holds grid can be called twice in quick succession

Bug #1705286 reported by Galen Charlton on 2017-07-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

While testing the patch for bug 1669907, I noticed that the grid provider for the View Holds tab in the record details page in the staff interface is getting invoked twice when switching _back_ to that tab:

- once directly, per line 1668 of cat/catalog/app.js
- once by the pickup_ou_changed handler

That manifested as the contents of the grid getting duplicated. While the patch for bug 1669907 works around the problem, it doesn't address the root cause. Avoiding the duplicate invocations of provider.get() would be better.

Evergreen 2.12+

Galen Charlton (gmc) on 2017-07-19
Changed in evergreen:
importance: Undecided → Medium
Andrea Neiman (aneiman) on 2017-07-19
tags: added: webstaffclient
Cesar V (cesardv) on 2017-07-19
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
Cesar V (cesardv) wrote :

Galen, I think either there's a bug in that grid or I am just not able to find where/how the provider.get() refresh code is getting called twice.

I've added code that prevents the refresh from being done unless the copy has actually changed, but unfortunately I still can't seem to get around the hack I had made for the related bug, as I haven't been able to trace where the double refresh is coming from.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/LP1705286_webstaff_ViewHolds_grid_refresh

Cesar V (cesardv) on 2017-07-25
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers