Carousels: shelving location selector should limit initial set of choices

[Galen Charlton]

The shelving location selector in the carousels administration form displays all shelving locations by default. However, for somebody in a consortium who is trying to set up a carousel applicable only to their system, that can potentially have them wading through many shelving locations owned by other systems.

It would be handy if the selector could initially display a more relevant set of shelving locations (perhaps all those owned by ancestors and descendants of the workstation OU?) by default (while still giving the user a way to access other systems' locations).

Evergreen 3.4+

[Terran McCanna (tmccanna)]

Marking it as a wishlist because it's not really a "bug," but it would be a really nice usability improvement.

[Michele Morgan (mmorgan)]

Adding a link to related bug 1955052

[Jennifer Pringle (jpringle-u)]

I think this is a bug, not a wishlist.

With the number of shelving locations we have in our consortium the shelving location not scoping to the workstation or user's working location makes carousels unusable for us.

[Galen Charlton (gmc)]

A patch is available at the tip of user/gmcharlt/lp1863387_tune_location_multi_select / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1863387_tune_location_multi_select

[Jeff Davis (jdavis-sitka)]

Noting that the patch incorporates a fix for bug 1980887.

[Gina Monti (gmonti90)]

Feedback Fest 9/22

I'm still getting a list of shelving locations from all system levels when creating a new carousel even with the branch I would like to use selected.

[Jeff Davis (jdavis-sitka)]

I think that is the intended behavior: the list includes locations belonging to ancestors or descendants of the org you've selected. Selecting BR1 shows you shelving locations belonging to BR1, SYS1, or CONS, but not those belonging to BR2 or SYS2. The shelving location selector in staff catalog search works the same way.

[Gina Monti (gmonti90)]

I have been testing this with BM1. I'll submit a screenshot.

[Terran McCanna (tmccanna)]

BM1 is nested under BR3 which is under SYS2, so that screenshot looks right.

However, it looks like it is only listing ancestors, not descendents. If I choose CONS, I only get CONS. If I select SYS2, I get CONS and SYS2, but not SYS2's branches.

[Terran McCanna (tmccanna)]

Note that I rebuilt my test server and tried again to be sure I wasn't having configuration issues, but it's still only showing ancestors, not descendants, in the dropdown.

[Jeff Davis (jdavis-sitka)]

I checked again and I'm also seeing ancestors only, not descendants (sorry for the confusion!).

[Jeff Davis (jdavis-sitka)]

Although the initial bug report mentions showing both ancestors and descendants, I think the feeling at Sitka is that it's not necessary to see the descendant shelving locations, especially since that seems to be how the shelving location selector works elsewhere in the client. Limiting to the selected org unit and its ancestors is the important part. Do we need to show descendants, or can the fix be committed as-is?

[Terran McCanna (tmccanna)]

In PINES we set up system level carousels that include items from their branch shelving locations, so we would definitely need to see descendants.

[Jennifer Pringle (jpringle-u)]

With this fix on our Sitka 3.9 test server I was able to set up a carousel for one of our systems and include items from multiple branches.

[Galen Charlton (gmc)]

I'll make a version of the patch that used eg-org-family-select instead.

[Galen Charlton (gmc)]

I've pushed a revised patch to user/gmcharlt/lp1863387_tune_location_multi_select-take2.

Rather than switching to eg-org-fmaily-select, I ended up just adding a checkbox to control whether descendants should be included or not.

[Susan Morrison (smorrison425)]

Tested with BR1 in the 'Owned by' field and could only see shelving locations for CONS, SYS1, BR1. I then added a shelving location for SL1, which only appeared in the dropdown once I clicked the 'Include descendants?' box for BR1. So all is working as expected on that front.

I was going to sign off but wanted to note something that may be for a separate bug (or NA): the 'Unset' function for Item Libraries and Shelving Location doesn't work. For those fields, there is the option to remove locations, so that may be why, and in that case, the 'Unset' option isn't needed for those two fields.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1863387_tune_location_multi_select-take2-signoff has my signoff:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1863387_tune_location_multi_select-take2-signoff

I don't think "Unset" is intended to be a function, it's just a placeholder to indicate that you aren't selecting a value from that dropdown. As noted, you would use the Remove button to remove a previously-added location.

[Galen Charlton (gmc)]

Confirming Jeff's statement re "Unset".

Pushed down to rel_3_10. Thanks for testing, Susan and Jeff!