Comment 19 for bug 1858448

Thanks for your work on this, Bill.

I was able to test many of the changes last Thursday. Here is what I found:

The tables themselves look good now. All the reports I've run directly on the database have led to positive results. The numbers match between servers with and without the tables.

Local Administration>Cash Reports is still incorrect. I expected this. If no one else gets to it, we will probably look into making changes ourselves.

For the most part, the tables integrate with Evergreen Reports well, too. I ran multiple test reports linking between Combined Circulations and All Payments with various payment types. They all matched the numbers from similar reports on a server without the tables.

I do, however, have some concerns with the IDL/Reporter. For example, it is not always obvious to the user if they are accessing the "all tables" or just the active/aged ones. Here are some changes that would be helpful:

-The link between "All Payments" (called "Transactions Payments" in Combined Circs) and "billings" goes to money.aged_billing. It should instead go to money.all_billings.

-The Core Source "Payments: All" still points to money.payment. It should be renamed "Payments" and be removed as a Core Source.

-"All Payments" should be renamed "Payments: All" and continue to point to money.all_payments.

- "All Billing Line Items" (called "Transaction Billings" in Combined Circs) should have a link to "Billable Transaction", similar to the "Billing Line Item" and "Aged Billing Line Item" sources. Note that with a circulation is aged, its row is completely removed from money.billable_xact. This link is still useful for active circulations.

- "All Payments" links to "Aged Circulation" as the only transactional link. There should be a link to "Billable Transaction" and/or "Combined Aged and Active Circulations"

- "Aged (patroness) Circulation" only links to "Payments: Aged" and "Aged Billings" via "Transaction Payments" and "Transaction Billings", respectively. Now that a flag can be set to age payments/billings separately from circulations, these should probably point to all payments and billings instead.