Comment 8 for bug 1855781

Revision history for this message
Jane Sandberg (sandbergja) wrote :

I did some more review of this branch today. It is looking good (and Jennifer, it does take care of bug 1771875), but I did catch two issues:

1) The shelving location dropdown is not showing the org unit labels next to the names of the shelving location. Right now, the dropdown includes entries like:

Stacks
Stacks
Stacks

which should actually be:

Stacks (BR1)
Stacks (CONS)

and so forth. The new <eg-item-location-select> component seems like a good tool for this task, but it's not quite ready to do so. That component takes an OU (or the workstation's OU) and generate a list of locations at that OU or its ancestors. However, an administrator might be working on shelving locations at a sibling or cousin OU, and would be unable to do so with the <eg-item-location-select> as it currently stands.

2) A few of the boolean fields can be NULL in the database. In the dojo UI, this was represented by dropdowns with the values "True", "False", and "Unset"/"Inherited". The Angular version doesn't give this option -- it only allows for True/False. Here are the ones that can be NULL:
* Renewal?
* Juvenile?
* Reference?
* Circulate?