Thanks Jane! My mistake for not grabbing ownership; we had some concurrent work happening. :-) Circ limit sets look good. I was inclined to rip out the help popover and put the help inline (see bug 2021862), but that looks good too. I'm more worried about combobox; there's been a lot of churn there in other branches, that I don't think are public yet. #31 looks addressed, though I notice we can still get duplicates with Permission Group and Circulation Modifier. I have an alternative strategy in a follow-up commit. Here's a branch with that and my sign-offs for the other changes: collab/phasefx/lp1855781-circulation-policy-configuration2
Thanks Jane! My mistake for not grabbing ownership; we had some concurrent work happening. :-) Circ limit sets look good. I was inclined to rip out the help popover and put the help inline (see bug 2021862), but that looks good too. I'm more worried about combobox; there's been a lot of churn there in other branches, that I don't think are public yet. #31 looks addressed, though I notice we can still get duplicates with Permission Group and Circulation Modifier. I have an alternative strategy in a follow-up commit. Here's a branch with that and my sign-offs for the other changes: collab/ phasefx/ lp1855781- circulation- policy- configuration2