Comment 4 for bug 1855781

Revision history for this message
Tiffany Little (tslittle) wrote :

I'm looking at this on the feedback fest server and have a few observations.

* I do see the dividers, but it looks like there's no padding between the dividers and the fields, so it causes the dividers to overlap into the fields slightly.

* The Cancel and Save buttons at the bottom of the form are misaligned. Cancel is too far down.

* Aside from the Permission Group, it doesn't appear to show which fields are required. It looks like at the very least Active, Org Unit and Group can't be null but only Permission Group appears to have the "Required?" flag.

* Following up on the previous bullet, if you save the editor with only active=true and permission group set (no org unit set), the form saves successfully. However, it appears to randomly pick an org unit.

* I'm an avid proponent of help popovers, so a help popover next to the Add button for Circ Limit Set Name saying that these are set in Local Admin > Circulation Limit Sets would be lovely. But that's a wishlist item and others may not think it necessary, so not a dealbreaker for me either way.