Comment 39 for bug 1855781

Revision history for this message
Jane Sandberg (sandbergja) wrote :

I've addressed Jennifer's feedback in #30 with an additional commit at collab/sandbergja/lp1855781-circulation-policy-configuration-2

I tried the following steps to confirm that limit sets are still applying in the enhanced concerto set (#35):

1. Modify an existing limit set to limit items to 5 items
2. Use the "linked entities" link to add a shelving location to the limit set
3. Looked up a list of barcodes for items at that location
4. Tried checking them out to a single patron.
5. On the sixth such checkout I attempted, I got the PATRON_EXCEEDS_CHECKOUT_COUNT warning

More testing is required, but from a reading of the new code, it does not appear to touch how circ limit sets are applied. It just had an unnecessary restriction in the UI.

Speaking of limit sets, there is an accessibility issue: the limit set combobox, "fallthrough" checkbox, and "active" checkbox are not associated with their labels.

Also, #31 still needs to be addressed.