Comment 2 for bug 1855781

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks very much for the branch, Zavier and Kyle. I think there are two things that this needs before being signed off:

* When I run ng lint, there are several lint errors. Most of them look pretty easy to fix (like missing semicolons, etc.)
* The dojo interface had a small line dividing fields used to match circulation policies vs. the actual policy effects. I think that some sort of separation is necessary. It doesn't have to be that little line -- actually, it would be nice to have a heading or something else that says what the groups actually are.