I've tested this branch and it does what it says as expected, with the 1 exception of users retrieved with lost cards, as mentioned by Martha above. Personally, however, I consider that to be the correct way to implement this change, because allowing lost cards to be used in addition has not set well with me in this discussion.
It contains Galen's original commit in addition to the followup so it can be tested as a single branch if desired. I don't, and would recommend the whole followup just be dumped in the bit bucket. Discuss.
I've tested this branch and it does what it says as expected, with the 1 exception of users retrieved with lost cards, as mentioned by Martha above. Personally, however, I consider that to be the correct way to implement this change, because allowing lost cards to be used in addition has not set well with me in this discussion.
So, here's my signoff for Galen's branch as-is: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1853363_ signoff / working/ user/jboyer/ lp1853363_ signoff
But, in the interest of giving admins enough rope to shoot themselves in the foot, here is a followup that also allows inactive cards to be used: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ jboyer/ lp1853363_ followup / working/ user/jboyer/ lp1853363_ followup
It contains Galen's original commit in addition to the followup so it can be tested as a single branch if desired. I don't, and would recommend the whole followup just be dumped in the bit bucket. Discuss.