Comment 11 for bug 1852782

Revision history for this message
Jane Sandberg (sandbergja) wrote :

This looks cool, Bill!

1) Applying an authority works well, except that it doesn't add the $0 to the field.

2) I like how the authority linker includes the authority record ID. Would it be possible to turn that ID into a link to open that authority record in a MARC editor (probably in a modal)?

3) The buttons for the physical characteristics wizard and the authority linker need some sort of accessible label (probably via an aria-label or title)

4) There's an issue with the right-click context menu for the Ills fixed field, which also affects the AngularJS Marc editor (see bug 1857919)

5) Additionally, the fixed fields with more than one character don't seem to update at all when you click on the right-click context menu. For example, when I select a value for the Lang or Ctry fixed fields, it doesn't get applied.

6) The editor in Vandelay doesn't seem to be working for me. Every time I try to go over to the "Edit Record" tab in a Vandelay queue, I get this error in the console:

QueuedRecordComponent.html:22
NullInjectorError: StaticInjectorError(BaseModule)[MarcEditorComponent -> HoldingsService]:
  StaticInjectorError(Platform: core)[MarcEditorComponent -> HoldingsService]:
    NullInjectorError: No provider for HoldingsService!