Comment 6 for bug 1850555

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks, Bill. Here's my feedback:

* If the permissions filter returns no working OUs, the acpl search fails with an error.
* The above was noted in the sandbox when testing with a non-superuser; the CREATE_WORKSTATION permission doesn't exist
* REGISTER_WORKSTATION does, of course, but UPDATE_COPY might be better for the purpose of the sandbox, as it more clearly shows differences between locations available to a circulator (who has UPDATE_COPY at the branch level by default) vs. those available to a cataloger (who has it at the system level)
* However, there's yet another glitch there: if the location is currently set to a value that the user doesn't have permission to access, the selector displays a blank selected value. The current value should always be display. "Stacks" is a great example here.
* It would be good if the location selector displayed the org unit (short)name after the location name for the selected location, not just the list entries.
* It might be nice to have an explicit option in the selection list for setting the location to null; this presumably would need a corresponding eg-item-location-select option to control whether to allow null in the first place.
* typo in a comment: "owneed"