Comment 2 for bug 1849370

Revision history for this message
Dan Briem (dbriem) wrote :

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1849370_mark_damage_modal_usability

The fee input removes itself when cleared because it's bound to same prop that conditionally renders the interface when it's not null.

The input is near the edge so the modal could accidentally close when drag selecting the input value to change it (the ui-bootstrap modal closes on mouseup over the backdrop, not just on click).

In testing I noticed if the cataloged item price is $0 the modal will keep reloading until you click the No Charge button. Also, if you otherwise charge a $0 fee without using the No Charge button, the user will end up being charged the full item price.

This branch uses a separate prop to conditionally render the interface, sets the modal backdrop prop to static, and handles the apply_fines param on submit just before the API call.