Comment 3 for bug 1846552

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for this nice interface, Zavier. Here are a few observations:

1) The new table list component is not usable with a keyboard, and does not use the aria-grabbed and aria-dropeffect properties. See here for more info: https://dev.opera.com/articles/accessible-drag-and-drop/ and https://salesforce-ux.github.io/dnd-a11y-patterns/#/sortB?_k=z75uvf

2) If it's not too inconvenient, could you rename copy-location in the code path, CopyLocation in the class names, and copy_location in the route to shelving location, to avoid the mismatched terminology?

3) It's very easy to lose changes if you navigate away from this interface without clicking the Save Changes button. It would be helpful to have an alert if the user tries to leave without saving their changes OR just saving the changes automatically whenever they move a location.

4) I'm wondering if table-list is the best name for the component. Maybe something like sortable-list instead?