Comment 15 for bug 1846354

Since installing this code on a 3.4.2 PINES test server broke things, we tried it again on a fresh server with current master and Concerto data. To test, we set up the clean server, then added some notes, messages, and alerts to accounts before applying the new code and conversion script. Again, the code broke a lot of existing functionality (eg, the only account that could log in to staff client was admin, no accounts could log into OPAC, account edits produce errors...)

These are the alerts I added prior to applying the new code:
- alert added from patron edit screen
- note added, patron visible
- note added from penalties screen
- alert added from penalties screen
- block added from penalties screen
- alert, note, and block added from penalties screen and then archived

Problems Found with Old Converted Data:
-> Conversion made a patron visible note *not* patron visible, and did not record staff person who'd entered it. The Staff Alert, Label, and Penalty Name are also blank.
-> Converted notes have blank Org Depth - should they?
-> Alert that was moved from the patron edit screen to this interface gets a creation date of the date the script processed it. I think this is probably the way it should work, but staff will need to understand that those alerts are actually older than the date stamp. Maybe when those alerts are converted, a message could be appended to them saying "(Converted to new format during upgrade)" or something like that?

I then created some new notes of various types and visibility:
-> It would be helpful if double-clicking on a note would open in Edit (right now it does nothing, you have to use the Actions dropdown or right-click to open)
-> If a non-alerting note is present, it no longer indicates in the patron summary bar that there is a note - without that indicator, staff will have no idea there are notes present.
-> When creating a new note/alert/block, it defaults to the branch level. PINES needs this to default to the consortium level (especially for blocks). Maybe a new setting is needed?

Authentication / Account Problems Found:
-> I could not test the staff client with any type of account other than admin because login failed with every Concerto staff account I tried.
-> I could not test OPAC visibility of notes because all logins failed, including admin.
-> Tried editing accounts and got error "Patron Update Failed" every time.