Angular admin pages need filters

Bug #1846042 reported by Jeff Davis on 2019-09-30
30
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
3.3
High
Unassigned
3.4
High
Unassigned

Bug Description

Dojo-based admin pages had a filter function that let you display only rows matching user-specified values. Filtering is an essential feature when you're dealing with a large number of rows (e.g. bookable resources, hold matrix, etc.). This functionality is currently lacking in Angular.

Filtering capability was added to eg-grid in EG 3.4 (bug 1831788), but it doesn't appear to be enabled anywhere. One solution is to make these filters available on all admin pages, preferably with an option that allows the user to show/hide filters since they clutter the grid. However, this won't solve the problem on 3.3 since that release doesn't have grid filtering.

Changed in evergreen:
milestone: none → 3.4-beta2
importance: Undecided → High
tags: added: admin-pages regression webstaffclient
Changed in evergreen:
status: New → Confirmed
Galen Charlton (gmc) wrote :

I've pushed a WIP patch to collab/gmcharlt/lp1846042_admin_page_filters to enable grid column filtering for most Angular admin pages. This isn't a complete patch, but should be enough for useful initial testing.

Galen Charlton (gmc) on 2019-10-02
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Jeff Davis (jdavis-sitka) wrote :

From initial testing of Galen's branch, filters appear on basic admin pages (including hold policies, booking resources, and the various server admin pages) and work correctly.

Some pages have both an org unit filter and a filterable org unit column. The filters work just fine together, but having both is arguably redundant and confusing.

With a visible filter on every column, admin pages can get very cluttered. Maybe there could be a small button next to each column name to show/hide the filter for that column? The button could change color when a filter has been applied on that column.

With a large number of columns, the filters quickly become misaligned with the columns, so that you can't tell which filter applies to which column (see Local Admin > Hold Policies for a good example). Perhaps columns should expand to accommodate the width of the filter when the filter is visible?

Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Jeff Davis (jdavis-sitka) wrote :

TODO: Confirm whether the issues reported here are resolved by the fix for bug 1855931, combined with Galen's WIP branch above.

Changed in evergreen:
status: Confirmed → New
milestone: 3.4.3 → 3.5.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers