Comment 26 for bug 1842297

Revision history for this message
Julian Clementson (oajulianc) wrote :

Jane, it looks as though your signoff branch is already rebased, so I don't need to do that.

I was going to add my signoff to your commit for using BasicAdminPageComponent instead of a custom component, but during testing I spotted a small issue. Previously my custom component set default values on a few of the fields. These defaults are mentioned in the documentation, and some of them are recommended not to be changed unless you are certain what you're doing. So I would like to keep them.

Rather than re-introducing a custom component with all the resultant code duplication, I have proposed bug 1989348 as a proposal to be able to set defaultNewRecord via routing data.

I have an implementation of that proposal, with unit tests, which I will commit for comment shortly.