Comment 2 for bug 1840327

Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Mike. Reviewing code and I have some suggestions.

1. For consistency and added flexibility, I suggest making the new isReadonlyOverride function behave the same as the existing isRequiredOverride function. I've pushed a commit w/ sandbox example here that does that:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840327-ang-standing-penalties

2. Avoid adding CSS for things like '.red', when you can use bootstrap classes instead (e.g. text-danger).

3. I think this is a good use case for the rowFlairCallback functionality in the grid. It allows you to set icons and tooltip/title text describing the purpose of the "flair". See rowFlairIsEnabled and rowFlairCallback in the Sandbox. Note to set the flair title, it will require an in-template <eg-string /> for i18n support.