Comment 4 for bug 1840053

Revision history for this message
John Merriam (jmerriam) wrote :

Hi Mike.

I do not have any timing information beyond a general seat of the pants feel that Evergreen seems a bit faster with these changes.

I'm not sure how it would be possible for old information to be reported?

Regarding side effects, I would argue that it is a bad idea to use logging statements to do anything other than log information. I didn't analyze every logging statement that I touched in detail but I didn't notice anything that looked like it was doing that.

The only logging statements that were changed in my branch are those that are at log level info or higher (not level error or warn) that are also doing something more than pulling together quoted strings and scalar variables. The ones that were changed involve something like calling methods, pulling data from arrays or hashes (which could be slow if they are large), or using the data dumper.

We run at log level warn because info is too noisy for us. warn seems to give a good balance of information vs noise.