Comment 7 for bug 1839369

Thanks for the great work, Terran.

I re-read the original bug report, which mentioned that "[t]he disappearance of the text can cause users with cognitive disabilities to grow confused or forget what should be entered into the field."

And I just realized that your branch does not help with this, unless the user is also using some assistive technology that makes use of aria-label. Even with your branch, if a user starts typing and then forgets what the field is about, they still don't have a visible label to remind them.

I could see two ways to do this: do a visible <label> (no sr-only) instead of the aria-label. Or change the text of the button from "Search" to "Search catalog".

Sorry for not thinking of this earlier!