Oddly enough, I'm not seeing the issues that Lynn mentioned in comment #15, but I am seeing others:
1- The page title should probably be "Library Settings Editor" for consistency with the Local Admin menu (and for user-friendliness)
2- I keep trying to hit Enter after typing in a filter word and it doesn't work. Tab works, but it seems like Enter should do the same thing.
3- The filter appears to be case-sensitive and it should not be. For example, "send" should bring up "Sending email address for patron notices" but it does not ("Send" does).
4- I'm a bit unclear what the import/export buttons are for. To save a backup of a library's settings? To be able to edit the settings outside of Evergreen to be able to apply settings to a new branch? A use case would be helpful for testing purposes. (I did test, and my exports & imports worked, but I'm just not sure what the intention of the feature is.)
5- Clearing a filter does not reset you to the first page of results, which I would expect it to do. For example, If I filter for "holds" then go to the second page of results, then clear the filter, it keeps me on the second page of results even though the results are different.
6- My grid changes are not saving.
I'm going to remove the pullrequest for now, as I think it needs a few more tweaks.
Oddly enough, I'm not seeing the issues that Lynn mentioned in comment #15, but I am seeing others:
1- The page title should probably be "Library Settings Editor" for consistency with the Local Admin menu (and for user-friendliness)
2- I keep trying to hit Enter after typing in a filter word and it doesn't work. Tab works, but it seems like Enter should do the same thing.
3- The filter appears to be case-sensitive and it should not be. For example, "send" should bring up "Sending email address for patron notices" but it does not ("Send" does).
4- I'm a bit unclear what the import/export buttons are for. To save a backup of a library's settings? To be able to edit the settings outside of Evergreen to be able to apply settings to a new branch? A use case would be helpful for testing purposes. (I did test, and my exports & imports worked, but I'm just not sure what the intention of the feature is.)
5- Clearing a filter does not reset you to the first page of results, which I would expect it to do. For example, If I filter for "holds" then go to the second page of results, then clear the filter, it keeps me on the second page of results even though the results are different.
6- My grid changes are not saving.
I'm going to remove the pullrequest for now, as I think it needs a few more tweaks.