auto_renewal field stored as NULL/TRUE. Should be FALSE/TRUE

Bug #1839002 reported by John Amundson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.2
Fix Released
High
Unassigned
3.3
Fix Released
High
Unassigned

Bug Description

In the table action.circulation, the auto_renewal field is set to TRUE for auto-renewals but NULL for all other circs. Auto-renewals should follow the pattern of other renewal types and be set to FALSE for circulations that are not auto-renewals.

Having the field default to NULL can cause issues for reports, (for example "auto_renewal=FALSE" would return no results).

Revision history for this message
John Amundson (jamundson) wrote :

Related bug: #1835085

Revision history for this message
John Amundson (jamundson) wrote :

Related bug: Bug #1835085

Revision history for this message
Michele Morgan (mmorgan) wrote :

I can confirm that rows in the action.circulation table created by autorenewals have a NULL auto_renewal field in our 3.2.4 system.

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: none → 3.4-beta1
assignee: nobody → Jason Stephenson (jstephenson)
Changed in evergreen:
status: Confirmed → In Progress
Changed in evergreen:
importance: Undecided → High
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Patch branch in working/user/dyrcona/lp1839002-auto_renewal-default-false

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1839002-auto_renewal-default-false

We've had this on our training server at CW MARS for the past week with no untoward effects, so I think it is time for the pullrequest tag.

Changed in evergreen:
status: In Progress → Confirmed
assignee: Jason Stephenson (jstephenson) → nobody
tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta1 → 3.4-beta2
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, and rel_3_2. Thanks, Jason!

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4-rc
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.