Autorenewal sets both desk_renewal and auto_renewal to TRUE for new circ

[Michele Morgan]

Evergreen 3.2.4

When a circulation is renewed by the auto renewal action trigger, the new row created in action.circulation has desk_renewal and auto_renewal both set to TRUE.

Only the auto_renewal field should be set to TRUE, desk_renewal should be FALSE

[John Amundson (jamundson)]

Related bug: bug #1839002

[Jason Stephenson (jstephenson)]

I see two obvious ways to fix this:

One is to add auto_renewal as a field in the Circ::Circulater::Circulator class and pass auto_renewal => 1 as an argument when doing the renewals via the auto-renewal trigger. Then, modifying the Circulator object's constructor to not set desk_renewal if auto_renewal is true.

The second way is to modify the Circulator's build_checkout_object method to set desk_renewal to false when it detects that an auto-renewal is being done.

The second method touches less code, but the first seems to fit in better with the way that Evergreen already processes renewals, and it looks like the second method will need to be done in both cases if the open-ils.circ.renew.auto method is retained because someone may call it in custom code without the auto_renewal argument.

[Jason Stephenson (jstephenson)]

Working branch: user/dyrcona/lp1835085-auto_renewal-not-desk_renewal

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1835085-auto_renewal-not-desk_renewal

We've tested this rather thoroughly on our training server and plan to implement it next month in production when we update to Evergreen 3.2.8.

[Jason Stephenson (jstephenson)]

I forgot to mention that this branch requires the fix for bug 1835577 installed to work properly. The web client fixes specifically need the IDL changes in the top commit on that branch.

[Galen Charlton (gmc)]

Pushed to master, rel_3_3, and rel_3_2. Thanks, Jason!