Comment 2 for bug 1837067

Revision history for this message
Bill Erickson (berick) wrote :

Thanks Jane. Issue confirmed. I've pushed another branch which merges your changes, but tweaks the solution to the main issue.

I have no strong preference for using await/async, but I didn't want to leave the impression that was the source of the bug. The problem was the unwatched Observable returned by getNextCopy() (pcrud.retrieve() under the covers). Since nothing subscribed, piped, etc. the Observable never fired and the next copy was never fetched from the network.

Of course, if removing the await/async (e.g. as a preference) was intentional, that's fine, I'll sign off on your original commit.

Commit also removes an unnecessary throwError() and its import.

To reduce churn, I squashed my changes into your commit.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1837067-replace-bc-race