Comment 3 for bug 1835982

Revision history for this message
Galen Charlton (gmc) wrote :

I like this approach and the patch works for me. I've pushed a signoff to user/gmcharlt/lp1835982_signoff; that branch also contains a follow-up to add cell value print handlers to the holdings view grid in the Angular staff catalog.

I would be comfortable with this going in as is or with additional follow-up patches to add cellPrintValue handlers for the remaining grids that use cellTemplate. In the former case, though, a new bug should be filed so we don't forget about the remaining grids.

I wonder how hard it would be to add a custom ng-lint rule to complete about eg-grid-columns that use cellTemplate bug lack cellPrintValue.