I have pushed a working branch that is ready for more eyes. It does the following:
1. Sets the auto_renewal_remaining fields of the circulation and aged_circulation tables to not allow nulls.
2. Sets the max_auto_renewals column on config.rule_circ_duration to not allow nulls.
3. Updates the IDL to indicate that the above columns are required, along with the max_renewals column on config.rule_circ_duration.
4. Updates the concerto data load so that the required columns get values.
5. Updates the pgtap and Perl tests as appropriate for the schema change.
6. Adds a regression test to make sure that that columns do not allow null values again in the future.
The branch is working/user/dyrcona/lp1835953-auto-renewal-remaining-not-null: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1835953-auto-renewal-remaining-not-null
I have pushed a working branch that is ready for more eyes. It does the following:
1. Sets the auto_renewal_ remaining fields of the circulation and aged_circulation tables to not allow nulls.
2. Sets the max_auto_renewals column on config. rule_circ_ duration to not allow nulls.
3. Updates the IDL to indicate that the above columns are required, along with the max_renewals column on config. rule_circ_ duration.
4. Updates the concerto data load so that the required columns get values.
5. Updates the pgtap and Perl tests as appropriate for the schema change.
6. Adds a regression test to make sure that that columns do not allow null values again in the future.
The branch is working/ user/dyrcona/ lp1835953- auto-renewal- remaining- not-null: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp1835953- auto-renewal- remaining- not-null