Hi Jane, thanks for testing Bill's branch. A couple thoughts...
Re (1), there are a few ways that the delimiter can be overridden, but the (arguably) "best" way is to pass a delimiter to the new record constructor (the internal one, implemented via the MARC21.Record class) in the calling code. We could either embed that desire directly in Open-ILS/src/eg2/src/app/staff/share/marc-edit/marcrecord.ts or allow users of the wrapper to supply, say, a second constructor argument that can override the default delimiter. We can also forcibly set the default text format delimiter by setting MARC21.Record.delimiter to $ before loading records via the TypeScript wrapper.
Re (2), for historical consideration, we use one space rather than two because when the flat text editor was created we intentionally wanted to maintain compatibility with the output of the as_formatted() method from the MARC::Record Perl module. The ability to take the output of as_formatted() and pass it to the Javascript implementation was seen as important because we use MARC::Record internally on the server side, and it makes shipping flat text to the client simpler.
Hi Jane, thanks for testing Bill's branch. A couple thoughts...
Re (1), there are a few ways that the delimiter can be overridden, but the (arguably) "best" way is to pass a delimiter to the new record constructor (the internal one, implemented via the MARC21.Record class) in the calling code. We could either embed that desire directly in Open-ILS/ src/eg2/ src/app/ staff/share/ marc-edit/ marcrecord. ts or allow users of the wrapper to supply, say, a second constructor argument that can override the default delimiter. We can also forcibly set the default text format delimiter by setting MARC21. Record. delimiter to $ before loading records via the TypeScript wrapper.
Re (2), for historical consideration, we use one space rather than two because when the flat text editor was created we intentionally wanted to maintain compatibility with the output of the as_formatted() method from the MARC::Record Perl module. The ability to take the output of as_formatted() and pass it to the Javascript implementation was seen as important because we use MARC::Record internally on the server side, and it makes shipping flat text to the client simpler.