* I was unable to create a carousel from a bucket. Whenever I tried to do so, it failed silently, I got redirected to the carousel admin screen, and I got the following error in osrfsys.log:
open-ils.cstore ERROR inserting container::carousel object using query [INSERT INTO container.carousel (id,type,owner,name,bucket,creator,editor,create_time,edit_time,age_filter,owning_lib_filter,copy_location_filter,last_refresh_time,active,max_items) VALUES (DEFAULT,1,4,'My bucket',DEFAULT,1,1,DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT);]: 3505682 3505682: ERROR: null value in column "max_items" violates not-null constraint
* On a related note, the fm-editor allows users to attempt to create a carousel without setting the maximum number of items. This always fails without a descriptive error. I pushed a follow-up commit to Bill's branch to mark max_items (and a few others) as required in the IDL, which also makes them required in the UI. That can be found at user/sandbergja/lp1832897-carousel-integration
* The new multi-select is cool! It does have an accessibility issue, though. The comboboxes have no labels associated with them. I don't know what the best practice for labeling repeatable inputs is, but they should have *some* labels for sure. Note that a few other components have an Input called domId that allows the fmeditor component to associate form controls and their labels.
This is fun to play with! Two comments:
* I was unable to create a carousel from a bucket. Whenever I tried to do so, it failed silently, I got redirected to the carousel admin screen, and I got the following error in osrfsys.log:
open-ils.cstore ERROR inserting container::carousel object using query [INSERT INTO container.carousel (id,type, owner,name, bucket, creator, editor, create_ time,edit_ time,age_ filter, owning_ lib_filter, copy_location_ filter, last_refresh_ time,active, max_items) VALUES (DEFAULT,1,4,'My bucket' ,DEFAULT, 1,1,DEFAULT, DEFAULT, DEFAULT, DEFAULT, DEFAULT, DEFAULT, DEFAULT, DEFAULT) ;]: 3505682 3505682: ERROR: null value in column "max_items" violates not-null constraint
* On a related note, the fm-editor allows users to attempt to create a carousel without setting the maximum number of items. This always fails without a descriptive error. I pushed a follow-up commit to Bill's branch to mark max_items (and a few others) as required in the IDL, which also makes them required in the UI. That can be found at user/sandbergja /lp1832897- carousel- integration
* The new multi-select is cool! It does have an accessibility issue, though. The comboboxes have no labels associated with them. I don't know what the best practice for labeling repeatable inputs is, but they should have *some* labels for sure. Note that a few other components have an Input called domId that allows the fmeditor component to associate form controls and their labels.