Code reviewed and tested. Does what it says. And +1 for building with ControlValueAccessor by default.
I pushed a sign-off branch here, which also resolves a minor merge conflict and removes the redundant FormsModule import.
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830432-org-family-select
Note however the unit tests are failing for me. Boils down to:
'null is not an object (evaluating 'includeAncestors.nativeElement')'
For reasons that are not obvious to me (the code looks right), lines like this are returning null:
includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
Hoping others can confirm.
Code reviewed and tested. Does what it says. And +1 for building with ControlValueAcc essor by default.
I pushed a sign-off branch here, which also resolves a minor merge conflict and removes the redundant FormsModule import.
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1830432- org-family- select
Note however the unit tests are failing for me. Boils down to:
'null is not an object (evaluating 'includeAncesto rs.nativeElemen t')'
For reasons that are not obvious to me (the code looks right), lines like this are returning null:
includeAncestors = fixture. debugElement. query(By. css('#family- test-include- ancestors' ));
Hoping others can confirm.