Hatch omnibus circa 3.3 (Java updates and more)

Bug #1830391 reported by Bill Erickson
62
This bug affects 11 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.3
Won't Fix
Undecided
Unassigned
3.4
Fix Released
Undecided
Unassigned

Bug Description

Evergreen 3.3 era

Combo bug for:

https://bugs.launchpad.net/evergreen/+bug/1824391
https://bugs.launchpad.net/evergreen/+bug/1825896
https://bugs.launchpad.net/evergreen/+bug/1817932

Related dupe bugs:

https://bugs.launchpad.net/evergreen/+bug/1741299
https://bugs.launchpad.net/evergreen/+bug/1825891

-----

Collection of Hatch and Hatch-related Evergreen improvements and features. Opening this combo bug since the various branches are starting to step on each other's toes. Similarly, creating Windows installers for all of the features will get messy and error prone.

Changes included:

1. Migrating to local OpenJDK and OpenJFX builds for all OS's.
2. Updating from Java 8 to Java 11
3. Support for storing workstations in Hatch when available, including migrating existing workstation data from the browser into Hatch.
4. Populate the workstation name field with the hostname of the PC as reported by Hatch when available.
5. Support for a new stock printer called the Hatch File Writer which translates print content into text and writes the data to a file on the PC in the Hatch profile directory. The file is named "receipt.$printContext.txt".

Branch and Windows build en route.

Revision history for this message
Bill Erickson (berick) wrote :

Windows build posted:

https://evergreen-ils.org/downloads/Hatch-Installer-0.3.2.exe

Linux users will need to run the new fetch-deps.sh file before compiling and running Hatch.

Evergreen Branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830391-hatch-omnibus-java-workstations-files

Hatch Branch:

https://git.evergreen-ils.org/?p=working/Hatch.git;a=shortlog;h=refs/heads/user/berick/lp1830391-hatch-omnibus-java-workstations-files

Testing:

* Confirm existing workstation registrations are migrated to Hatch (files eg.workstation.all / eg.workstation.default)

* Register a new workstation and confirm it defaults to the PC hostname.

* Configure printing to use the Hatch File Writer, test print, confirm it created the appropriate receipt.$context.txt file in the Hatch profile directory.

* Confirm the Hatch profile directory is now c:\\ProgramData\Hatch on Windows.

===

Note while testing I found the actor.workstation_setting table did not have a unique constraint on name + workstation. The tip commit of this working branch resolves that. It can be easily extracted for back-porting.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Bill Erickson (berick) wrote :
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta1 → 3.4-beta2
Revision history for this message
Bill Erickson (berick) wrote :
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Rebasing to master and fixing a thinko in the hatch-enabled workstation setting lookup code.

Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

New rebased branch pushed that includes a check for duplicate workstations before applying the UNIQUE constraint on the actor.workstation_setting table (as discussed in IRC dev meeting).

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1830391-hatch-omnibus-java-workstations-files-6

Revision history for this message
Jason Boyer (jboyer) wrote :

I tried this out today and all of the tests passed with flying colors. This is a great collection of features, thanks Bill.

Here's my signoff branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1830391_signoff / working/user/jboyer/lp1830391_signoff

tags: added: signedoff
Jason Boyer (jboyer)
Changed in evergreen:
milestone: 3.4.2 → 3.5-alpha
Revision history for this message
Bill Erickson (berick) wrote :
Revision history for this message
Jason Boyer (jboyer) wrote :

Whoops, yeah, not a lot of good to have one and not the other.

https://git.evergreen-ils.org/?p=working/Hatch.git;a=shortlog;h=refs/heads/user/jboyer/lp1830391_signoff / working/user/jboyer/lp1830391_signoff

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Hatch code merged to master along with version tags.

Evergreen code merged to master and 3.4. Commits include a minor eg2 test spec repair.

I have not merged the code to 3.3. Practically every commit results in a merge conflict, in part because of the server print template support in 3.4+, but also just code drift in the rapidly changing Angular code. I have left it for now, since it will require some work on 3.3 system.

Note the new version of Hatch will work fine on 3.3 systems. If this code remains unmerged, then 3.3 will miss out on the file writer feature and the Hatch workstation storage.

Changed in evergreen:
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Noting that if this is backported to 3.3, the fix for bug 1857710 will need to be added to 3.3 as well.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.