Comment 5 for bug 1830065

Revision history for this message
Jason Stephenson (jstephenson) wrote :

The A/T phase already strips -, <space>, (, and ). <space> is a literal space character. You can see this at line 397 of Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Rector.pm in master.

I proposed [:space:] and [:punct:]. However, using the latter might be overkill because you can set up aliases for Email -> SMS gateways with some providers. I know that Thomas Berezansky of MVLC had this setup for his account.

I was about to mark this bug as invalid, but I'm going to set it back to New so we can have some discussion on what extra validation should be done, if anyone.

I have verified that the notification that triggered my making this bug was indeed sent to, and accepted by, our email provider. What happened after that, I can't say. This is another case of me jumping the gun again.

The only characters that I see in our database that will possibly break for our users are Unicode smart quotes. Soem of our staff seem to have entered notes in these fields on some patron's accounts but they basically say that no call is necessary. I have not, yet, looked to see what these look like in the A/T tables or email logs.