Comment 2 for bug 1824709
Revision history for this message
| Mike Risher (mrisher) wrote Re: Angular Comboboxes should have an ID attribute | #2 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I tested using the MARC Batch Import page. I used WAVE to determine that "Apply/Create Form Template" is the field that is being fixed.
Without the patch: The source code for that combobox appears to be good valid accessible HTML code. I see an "id" on the combobox and a "for" attribute on the label. I tested it out with a screen reader and it reads me the full correct label.
With the patch: Wave tells me that one error involving a "missing form label" was fixed. Instead of 10 errors there are only 9.
So it's not clear to me what actually got improved by applying the patch. I can't find a missing form label that was addressed. WAVE shows an improvement, but I'm unable to confirm.
Did I make some error in my testing procedure? I will hold off marking this as "needs repatch", til I confirm I'm fully understanding the testing.