Comment 21 for bug 1823367

Okay, new branch posted here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1823367-ang-catalog-post-3.3-omnibus-rename

working/user/dbwells/lp1823367-ang-catalog-post-3.3-omnibus-rename

This signs off on Bill's latest commits, then adds two more. The first is a straight-up relabeling change from "Copy" to "Item" in various eg2 interfaces. The second digs a little deeper at "volume" in some of the underlying code. Permit me to quote the commit message:

"It isn't really correct to use "volume" and "call number" interchangeably. This code substitutes various forms of the second for various forms of the first within the internal variable and function names. To help contain the change, it tries to only do so for values which are native to eg2, and not leaking from or into other interfaces.

Understanding that this change is somewhat disruptive, I still think it is in our overall best interest, as it will help us from falling into old habits, and it will help future coders better understand the relationship between the code and the interface."

I also feel like this is a bit of a now-or-never type change, and I much prefer now. The client isn't likely to undergo yet another major rewrite anytime soon, so this will be our best opportunity for quite some time to get our code and our user terminology on the same wavelength. If first reactions are negative, I hope folks will toss it over a few times before rejecting it.

It is also worth noting I did not do the same for Item/Copy. "Copy" is just a little more ingrained, given it's use at the DB layer, and that switch doesn't have quite the same urgency (IMHO). Not that I would necessarily mind if we ultimately did make that change, though.