Comment 2 for bug 1823041

Revision history for this message
Bill Erickson (berick) wrote :

This turned out to be considerably less disruptive than expected.

Code pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823041-dialog-dismiss-resolve

From the commit:

Angular dialogs now only result in a promise rejection when an unexpected error occurs. Dismissing a dialog via Esc, Cancel button, cross-click, body-click, etc. no longer result in a rejection. In these situations, the response value will be set to 'null' and a new boolean field 'dismissed' on the dialog object will be set to true.

For the current code, this primarily affects confirm dialogs, which previously rejected the dialog promise when the user selected the "do not confirm" option. Now the confirmation state of the dialog can be inspected by the its boolean response value.

Additionally, this commit adds typescript support for "es2018.promise" which allows us to start using Promise.finally() handlers.

===

I don't consider this bug especially high priority, but it will impact working branches in progress, so the sooner we merge this one, the less translation work will be needed over time.