Comment 1 for bug 1823041

+1 to not treating closing a modal as an error.

While we're looking at the modals, though, I'm curious if they should return a Promise or an Observable instead. I ask because it seems like it could be very nice to handle success, error, and complete conditions (which RxJs provides), rather than just success and error.

See Angular Material's Observable-based modal: https://material.angular.io/components/dialog/overview

Also the "Handling the result as an observable" section of this blog post: https://aspnetaddict.wordpress.com/2017/10/28/making-ngbootstraps-modal-work-more-like-angular-material-dialog/