Comment 2 for bug 1821198

Yes, we do this all the time -- do a search, look at the results, perhaps add limiters or otherwise refine the search, select all and move to a basket as a way to move them to a bucket. I'm attaching a screenshot from OverDrive Marketplace showing how they handle this -- I like the fact that even though the number of search results appears with the pagination above, they repeat the number of records in the checkbox text to make it clear what the user is requesting.

Re: Galen's suggestions:

"Respecting the ctx.max_basket_size basket template parameter" -- Agree, his should work the same way whether the user is individually selecting titles to add to the basket or is selecting all results

"Asking the user to confirm that they really want to include all results" -- Always a good idea

"Ensuring that very large baskets don't create problems when trying to do batch actions on them, in particular, placing holds" -- True, but that's really a problem with basket size and holds, not with Select All. When the user is adding items to the basket, we don't know which action they are going to choose -- Place Holds may be a problem for a basket of 500 (or whatever) bib records, but adding the records to a bucket may not be. Would it be better to let users add as many records as they want up to the maximum basket size (whether they select them individually, by selecting all on each page, or selecting all search results) and then handle the holds issue when it comes up, either with a warning or a limit that the system can only process holds in batches of 100 or whatever, and send them to View Basket where they can select batches of titles to place holds.

Having the Select All option wouldn't change any of the max size and performance issues -- it just saves the user who really wants all the search results from having to go from page to page to page to select them all.