EDI Accounts shows EDI Attr set ID instead of label

Bug #1812670 reported by Tiffany Little on 2019-01-21
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Found on 3.2.2.

In the new Angularized EDI Accounts, the EDI Attribute set is now showing only the set's ID. It used to show the set's label/code. It should show the code.

Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) wrote :

This will affect the new booking admin as well. Need to teach the grid to render the selector fields...

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Support for grid selector field display pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1812670-ang-grid-selector-fields

From the commit:

* Teach PcrudService how to flesh link fields when a selector is defined on the linked class. This uses a new search/retrieve API flag {fleshSelectors:true}.

* Teach the grid how to render selector values when configured to do so via a new grid component attribute [showLinkSelectors]="true".

* Teach the Angular staff admin page to request linked selectors from pcrud and tell its grid to expect them.

* Adds utility function to IdlService for finding the selector for a given class + field.

---

Some comments on the implementation... By teaching PcrudService to optionally flesh linked selector fields, instead of teaching the grid to retroactively fetch linked selectors (e.g. inside getRows), we get the functionality we want without adding any additional network calls. It also keeps the nuts and bolts of data retrieval out of the grid.

With the linked branch, all auto-generated admin UI's (ACQ, Booking, Server Admin (Pending), ...) will automatically display link selector fields.

Changed in evergreen:
milestone: none → 3.2.4
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Changed in evergreen:
milestone: 3.2.4 → 3.2.5
John Amundson (jamundson) wrote :

Tested on a Evergreen 3.2.3 server set up for Bug-Squashing week.

I'm adding my sign off because from what I can tell, this works as intended in the ACQ Admin menus. Fields that used to display IDs now display labels/codes (like Edi Accounts>Provider and EDI Accounts>EDI Attribute Set; Claim Policy Actions>Claim Policy ID and Claim Policy Actions>Action (Event Type)).

Others more familiar with with the other modules, (i.e. Booking), doing might want to take a look too, but I can't find any issues looking at the changes in the ACQ Admin menus.

Thanks, Bill!

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

tags: added: signedoff
Bill Erickson (berick) wrote :

Code expanded and transferred to bug #1819179.

John, I appreciate the testing! Given the tested code has changed somewhat since your testing, I have opted not to add your sign-off.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers