Angular grid timestamp columns should have the option to display datePlusTime

Bug #1807764 reported by Jane Sandberg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

In the angular web staff client, you can create a timestamp column like so:

<eg-grid-column name="start_time" label="Start Time" i18n-label path="start_time" datatype="timestamp"></eg-grid-column>

The datatype="timestamp" attribute nicely puts the data from the database into a nice, human-readable date. However, there doesn't appear to be an option to display the full time (date + time) in the column with a nice format.

It looks like format.service.ts has a datePlusTime? property, which could be used to display that full time. If there were a nice way to pass this parameter in via some attribute in the <eg-grid-column>, it would be really handy.

Revision history for this message
Mike Rylander (mrylander) wrote :

I have not looked at the new Angular grid date and time code in detail, but the AngularJS version has quite a bit of tooling around the display of timestamps, including knowing how to respect the timezone of a related org unit. We leverage moment.js heavily for much of that. Just wanted to note that for whichever future-us ends up looking into this bug.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Here's a branch to handle just the grid option for displaying date + time (includes sandbox example).

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1807764-grid-datetime

Still need to implement timezone/org handling.

Bill Erickson (berick)
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Works well for me, Bill. Thanks! Here's a signoff branch: user/sandbergja/lp1807764-grid-datetime-signedoff

Should the timezone/org handling work live on this LP bug, or would it be better as a new LP bug?

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Just a note that I just split the timezone piece into a new bug: https://bugs.launchpad.net/evergreen/+bug/1812325 -- let me know if there's another piece of this puzzle that I'm missing.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.3-beta1
Revision history for this message
Bill Erickson (berick) wrote :

Thanks for the new bug, Jane. I have merged the commit for this bug into master for 3.3.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
Dan Wells (dbw2)
Changed in evergreen:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.